search

alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
10.97k stars 11.14k forks source link

Removing accents from coauthor names causes issues #2409

Closed kaanaksit closed 3 months ago

kaanaksit commented 5 months ago

Have you checked that your issue isn't already filed?

Bug description

Coauthor names are not highlighted when they have accents in their names

How to reproduce the bug

https://github.com/alshedivat/al-folio/blob/36bc24f7e4f8525ce6f00ccb234073771c898430/_layouts/bib.liquid#L69

The line above has remove_accents, and this causes issues if the surnames have accents or special characters from other languages.

Error messages and logs

The error message you got, with the full traceback if available. Please paste it between these triple backticks.

What operating system are you using?

Linux

Where are you seeing the problem on?

Running locally without Docker

More info

No response

george-gca commented 5 months ago

If you look at the line just below:

https://github.com/alshedivat/al-folio/blob/36bc24f7e4f8525ce6f00ccb234073771c898430/_layouts/bib.liquid#L70

This line means that we look for this clean name in the list of coauthors, which in this case are the keys: "adams", "podolsky", "rosen", "bach", "przibram", "schrodinger", "lorentz", "planck". Note that these are just keys to search for these coauthors. When writing their names in the publications we use the names provided in the bib entry, not this key.

What this means is, to ease the search process you should write the coauthors keys with simple chars, removing these special chars, while in the bib entries themselves you can keep all the special chars. Of course you can change this behavior for your site.