search

alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
11.37k stars 11.29k forks source link

Added lightbox2 functionality complete with an example (project_10) #2692

Open Picsiri opened 2 months ago

george-gca commented 2 months ago

What is this for?

Picsiri commented 2 months ago

What is a feature for? Anything you use it for.

I mostly needed it where I put 12 images in a row. With this you can actually see all of them. Also, in general I like if an image pops up when I click on it.

I am not sure about it but I guess imagemagick downscales the embedded images? In that case pop up does not enlarge the image but if you upload HD images...

george-gca commented 2 months ago

What is a feature for? Anything you use it for.

With this you assume we know what lightbox is for.

I mostly needed it where I put 12 images in a row. With this you can actually see all of them. Also, in general I like if an image pops up when I click on it.

Do you have a working example or screenshots? In this example the zoomable images pops when you click on them.

I am not sure about it but I guess imagemagick downscales the embedded images?

Not entirely sure, but I believe this is only currently happening on publication images like reported in #2668.

Picsiri commented 2 months ago

Oh, so the question was made in the contect of not knowing anything about this PR, now I get it :)

Well, here is lightbox2.

And an example is provided in 10_project. Basically the same as in the link above. Only this is integrated into alfolio.

I haven't seen the data-zoomable tag feature. Still this is a bit "more" than that as you can group images and navigate between them if you think they belong together.

Also, the images can be annotated.

Picsiri commented 2 months ago

Should I cancel the PR?

george-gca commented 1 month ago

Not needed. I will give it a look as soon as I can.

alshedivat commented 1 month ago

just catching up here: what's the advantage of lightbox2 over zoomable images we already have?

george-gca commented 1 day ago

Can you answer this @Picsiri?

Picsiri commented 1 day ago

sorry, I don't usually check my GitHub ...

For example you can group images, there are more mini image setting options.

I made a pretty looking gallery with 6 images in a row that are unrecognizable on that scale but it is clearly indicated that they belong together and you can view them in a carousel.