search

alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
11.37k stars 11.29k forks source link

Update entry_point.sh #2707

Closed pourmand1376 closed 2 months ago

george-gca commented 2 months ago

Can you check if this fixes it @0xAdriaTorralba?

0xAdriaTorralba commented 2 months ago

Can you check if this fixes it @0xAdriaTorralba?

Will do ASAP.

0xAdriaTorralba commented 2 months ago

Tried the fix (reverted to the "old" Gemfile.lock) and copied the entry_point.sh proposed here and it fails.

pourmand1376 commented 2 months ago

Thanks for testing it.

if you want to test it, you have to replace the docker-compose.yaml to build the image instead of using the upper-stream image. This is because the entry_point.sh is built into image and will change only when a new image is pushed. 

# this file uses prebuilt image in dockerhub
services:
  jekyll:
    build: .
    ports:
      - 8080:8080
      - 35729:35729
    volumes:
      - .:/srv/jekyll
    environment:
      - JEKYLL_ENV=development

I think if you revert the Gemfile into the previous version and then commit. After that, you shouldn't have any problems when having local deployments.

pourmand1376 commented 2 months ago

I merged the change since I'm pretty much sure that line was problematic and I should've changed that since we've added Gemfile.lock into repository.

george-gca commented 2 months ago

@0xAdriaTorralba can you test again in the same way? Now the docker image have the updated entry_point.sh.

pourmand1376 commented 2 months ago

Yep. Just make sure to pull new image.