search

alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
11.33k stars 11.28k forks source link

Add Image Version to Docker-Compose to pull the relevant image #2740

Closed pourmand1376 closed 1 month ago

pourmand1376 commented 1 month ago

This is to address

Since a lot of times, the only problem is that docker image is not consistent with the build. We have to somehow incorporate image version into repository.

I don't insist to provide it this way. Maybe there are other automatic ways which are better.

We can also calculate the relevant tag from git.

george-gca commented 1 month ago

I don't think I understand the problem. The issue is that the version of the libraries in Gemfile.lock are different from the ones installed in the Dockerfile? If so, I think the easiest solution we could give is to every time we update the dependencies we also update the version of the docker image and change it where it is used.

Now, I am not sure if this is the problem. Currently our users can use 2 different docker images:

  1. from https://github.com/alshedivat/al-folio/blob/c0d53e631630b19328f30f9e0da900ff1161eb27/docker-compose.yml#L4
  2. from https://github.com/alshedivat/al-folio/blob/c0d53e631630b19328f30f9e0da900ff1161eb27/.devcontainer/devcontainer.json#L5

Since I believe most recent users simply use dev containers because it is the easiest way to start, the problem might be in that path, but this is still to be confirmed.

pourmand1376 commented 1 month ago

The issue is exactly what happened right now.

The main branch has changes that docker image is corrupt. So, people should stick to the tagged version until the problem is solved. and we release a new version.

Also, we can not do much for dev container guys for now. Maybe we can change the whole starting image?

pourmand1376 commented 1 month ago

I applied this so that the current problem with docker image be solved via this approach.