search

alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
11.33k stars 11.28k forks source link

fix: do not included downloaded assets in jekyll-minifier #2749

Closed CheariX closed 1 month ago

CheariX commented 1 month ago

If download: true, the site deployment fails. This caused e.g. issue #2548.

I believe the issue appears because the 3rd party downloaded libs rely on ES6 Syntax, which jekyll-minifier cannot work on correctly. Also, I think we do not need to minify 3rd party downloaded libs at all.

While this PR does not fix the issue above, it at least ensures that the site can be deployed with download: true. We still need better ES6 support as suggested in #2571.