alshedivat / al-folio

A beautiful, simple, clean, and responsive Jekyll theme for academics
https://alshedivat.github.io/al-folio/
MIT License
11.27k stars 11.26k forks source link

Responsive Image SrcSet Creation Not Functioning Properly #2777

Closed dfuchss closed 1 month ago

dfuchss commented 1 month ago

Have you checked that your issue isn't already filed?

Bug description

In PR #2698, a filter was added for creating the .webp srcset for responsive images. However, the filter currently searches for ".jpg" and ".png" instead of "jpg" and "png", leading to no matches. This issue arises because the split operation removes the period from the extension, preventing the srcset from being generated for any figures. The filter needs to be updated to ensure that responsive image srcsets are created correctly for the appropriate file extensions.

How to reproduce the bug

Include a Picture (File Ending ".jpg"), enable imagemagick and check the produced generated source code (HTML) how the images are included

Error messages and logs

No response

What operating system are you using?

Mac

Where are you seeing the problem on?

Deployed site

More info

No response