alsoscotland / react-super-select

MIT License
95 stars 33 forks source link

Multiselect with Shift-key problem #122

Closed a1argus closed 7 years ago

a1argus commented 7 years ago

Multiselect with Shift-key not working if values are numerics converted to string like this: dataSource={[ {"name":100,"value":"100"}, {"name":200,"value":"200"}, {"name":300,"value":"300"}, ]}

_getOptionValueFromDataAttr converts them opportunistically to numerics but then _selectAllOptionsInOptionIdRange compares them to string and gets nothing

alsoscotland commented 7 years ago

@a1argus I will take a look at this soon.

alsoscotland commented 7 years ago

@a1argus Thanks for filing the bug.
https://github.com/alsoscotland/react-super-select/tree/v1.0.6