search

alsoscotland / react-super-select

MIT License
95 stars 33 forks source link

v 0.4.0 with React 0.13.x is throwing an error #60

Closed anuccio1 closed 8 years ago

anuccio1 commented 8 years ago

I was previously using v 0.1.16, and wasn't able to deselect in my multiselect dropdown, so I upgraded to 0.4.0, however now I am getting this error in my console:

Uncaught TypeError: this.refs.rssControl.contains is not a function_handleDocumentClick @ react-super-select.js?8d48:936

Is there a working version compatible with React 0.13.x???

alsoscotland commented 8 years ago

@anuccio1 The last version that worked for React <14 was 0.1.19 Give that a try and let me know what happens.

anuccio1 commented 8 years ago

Looks like that fixed that issue! Another question....looks like the clear all button isn't triggering on change...was this fixed in a future release as well?

alsoscotland commented 8 years ago

@anuccio1 yes. Unfortunately, that fix came after the upgrade so it may be a challenge to cherry-pick it. Try making a fork and adding the equivalent of this commit https://github.com/alsoscotland/react-super-select/commit/a51e6fe803e049b63f878f6eb45a2d37828fa5fd