alsterane / pylibnidaqmx

Automatically exported from code.google.com/p/pylibnidaqmx
Other
0 stars 0 forks source link

add support for reference triggering #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I don't see support for the reference triggered functions:

DAQmxCfgAnlgEdgeRefTrig()
DAQmxCfgAnlgWindowRefTrig()
DAQmxCfgDigEdgeRefTrig()
DAQmxCfgDigPatternRefTrig()

Original issue reported on code.google.com by tolis...@gmail.com on 15 Jun 2012 at 6:24

GoogleCodeExporter commented 9 years ago
I've attached a patch file for these functions (and the disable reference 
trigger).  However, I have only need for DAQmxCfgDigEdgeRefTrig() at the moment 
and it seems my DAQ device doesn't support several of the others, so I am 
unable to fully test.  But this might be a good enough starting point for you.

Original comment by tolis...@gmail.com on 15 Jun 2012 at 8:23

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch!
I have applied it to svn repo.
PS: patch was not actually a proper one but that's ok.

Original comment by pearu.peterson on 20 Jun 2012 at 11:23

GoogleCodeExporter commented 9 years ago
I've tested new funcionality on NI USB-4431. The functions 
DAQmxCfgDigEdgeRefTrig()
and DAQmxCfgDigPatternRefTrig() are ok, but DAQmxCfgAnlgEdgeRefTrig()
DAQmxCfgAnlgWindowRefTrig() are not working.
When using reference trigger with analog input you don't need prefix '/', it's 
required only for digital input. Please observe following diff output. Do you 
consider adding support for IEPE sensors?
1563,1564c1563,1565
<         if not source.startswith('/'): # source needs to start with a '/'
<             source = '/'+source
---
> #        if not source.startswith('/'): 
> # source needs to start with a '/'
> #            source = '/'+source
1622,1623c1623,1625
<         if not source.startswith('/'): # source needs to start with a '/'
<             source = '/'+source
---
> #        if not source.startswith('/'): 
> # source needs to start with a '/'
> #            source = '/'+source

Original comment by labakust...@gmail.com on 12 Jul 2012 at 6:32

GoogleCodeExporter commented 9 years ago
Thanks for the feedback! I have applied the corresponding patch to svn.
Regarding support additions, all patches are welcome.

Original comment by pearu.peterson on 12 Jul 2012 at 7:17