search

alstr / todo-to-issue-action

Action that converts TODO comments to GitHub issues on push.
MIT License
630 stars 121 forks source link

TODOs with same text are confused #216

Open naps62 opened 3 weeks ago

naps62 commented 3 weeks ago

I merged a pull request where two different TODOs had the exact same text (similar to what I reported in #215 )

it seems the action got confused, and committed both issue URLs to the same place, instead of one for each

alstr commented 3 weeks ago

Can you share your workflow settings and a code example?

rgalonso commented 4 days ago

I think I've uncovered this issue too. In my case, it was the same text in the same file. Is that the case for you too, @naps62? If so, I've resolved it and, once I clean it up, I'll be submitting a PR to address it.

alstr commented 15 hours ago

I think in the early days, when the action was simpler, there was an assumption that two TODOs in the same file with the same name was unlikely. So I can see how it would potentially not recognise both correctly, and if there was a way to improve things that would be good.