search

alstr / todo-to-issue-action

Action that converts TODO comments to GitHub issues on push.
MIT License
605 stars 115 forks source link

Issue is closed right after creation.. #50

Closed milewski closed 3 years ago

milewski commented 3 years ago

I have this issue where the action does detect the TODO and create the issue.. and close it right after referencing the same commit that created it...

image

image

alstr commented 3 years ago

Hi, that's strange.

I take it the issue was created in dab1adc? Please could you take a screenshot of the diff showing any additions/deletions of TODOs? Thanks.

milewski commented 3 years ago

This is the diff of dab1adc

image

milewski commented 3 years ago

I think maybe it has something to do with the triggers being set to push and pull request ... because when this happens the action run twice ... I merged the PR and now new Todo looks fine...

alstr commented 3 years ago

Hmm, I'm still not entirely sure. I take it there were no other TODOs in the diff, one that was removed?

Setting it to run on push and pull could result in it running twice. You may want to fine tune it with some of the options described here.

Even if it ran twice, I don't know why the TODO was closed immediately after. The only time it should do that is when it appears in the diff as a deletion. I'll look into it some more.

milewski commented 3 years ago

There were some other changes on the to-do on the same PR.. like changing /** to /* but other than this there was no commit that would remove it entirely and later add it back again...

alstr commented 3 years ago

If you change the TODO there is a chance that the original one will show in the diff as a deletion and the updated one as an addition. In theory that would close the old one and open a new one. If you can share more from the diff that would be useful, but I'll look into it anyway. Thanks.

alstr commented 3 years ago

I'm going to close this but if further information comes to light that you want to share, feel free. I've opened a couple of separate issues to look into improving the way the TODO extraction works (#62, #63).