alt3 / cakephp-swagger

Swagger plugin for documenting your CakePHP APIs

MIT License

64 stars 17 forks source link

Improves (new) Plugin Object configuration instructions #46

Closed bravo-kernel closed 6 years ago

bravo-kernel commented 6 years ago

Improves new Plugin Object instrutions.

codecov-io commented 6 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             master    #46   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       32     32           
=======================================
  Files             5      5           
  Lines            99     99           
=======================================
  Hits             99     99

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8d6022...914b3d7. Read the comment docs.

bravo-kernel commented 6 years ago

@pedro-stanaka please review, would appreciate your feedback

bravo-kernel commented 6 years ago

Still getting 404 errors on the assets locally, must be something in my application. Any pointers welcome.

pedro-stanaka commented 6 years ago

This is okay @bravo-kernel, better wording on the readme. I liked. Are you going to bump major?

bravo-kernel commented 6 years ago

I think this should become 2.1.0 once I get those 404s out of the way.

bravo-kernel commented 6 years ago

Moved parent::bootstrap(); to top as described in the book at https://book.cakephp.org/3.0/en/plugins.html#loading-a-plugin

bravo-kernel commented 6 years ago

@pedro-stanaka solved, assetMiddleware MUST be loaded (ofcourse), adding it to the README now

bravo-kernel commented 6 years ago

@pedro-stanaka please help me out here, or contact me on Slack to discuss. Just switched back to Cake 3.6.4 and all works as well there. So maybe no need to require CakePHP 3.6.6.

pedro-stanaka commented 6 years ago

Now that we changed the way we load the routes and assets. I think that is okay. I mean, it should work with 3.6.4.

bravo-kernel commented 6 years ago

OK, I will limit this to an update of the README then and will release 2.0.2 as soon as Travis turns green. Good job @pedro-stanaka and apologies for the noise, it's a bit hard to really focus sometimes due to lack of time.

pedro-stanaka commented 6 years ago

Yeah, I appreciate people like you that takes time to give back to the community @bravo-kernel ! Sorry for the delay as well! Have a nice day!

bravo-kernel commented 6 years ago

https://github.com/alt3/cakephp-swagger/releases/tag/2.0.2