search

alta3 / kubernetes-the-alta3-way

The greatest k8s installer on the planet!
223 stars 34 forks source link

Testing: persistent-configuration-with-configmaps - test references external files #28

Closed bryfry closed 1 year ago

bryfry commented 2 years ago

https://github.com/alta3/kubernetes-the-alta3-way/blob/f40038e2ea1732fa02b877c16b78a25515421ad2/labs/setup/persistent-configuration-with-configmaps/test.sh#L1-L8

@seaneon @sfeeser please update to reference repo-internal files. Testing fails when existent ~/mycode files are attempted to be read.

Confirmed this is not a 1.24 issue by getting the same error on the current main branch

bryfry commented 1 year ago

✅ persistent-configuration-with-configmaps

student@bchd:~/git/kubernetes-the-alta3-way$ tl persistent-configuration-with-configmaps                                                                                                                                    
[+] Cleaning cluster                                                                                                                                                                                                        
[+] Preparing persistent-configuration-with-configmaps                                                                                                                                                                      
[+] Setup complete                                                                                                                                                                                                          
[+] Testing persistent-configuration-with-configmaps                                                                                                                                                                        
error: error reading mycode/config/nginx-base.conf: no such file or directory                                                                                                                                               
error: error reading mycode/config/index-html-zork.html: no such file or directory                                                                                                                                          
error: error reading mycode/config/nineteen-eighty-four.txt: no such file or directory                                                                                                                                      
pod/nginx-configured created                                                                                                                                                                                                [-] Test failed

Fixed in https://github.com/alta3/kubernetes-the-alta3-way/commit/2c586c291b3c2a0d72993c4500e86a7b20bee2f0

student@bchd:~/git/kubernetes-the-alta3-way$ tl persistent-configuration-with-configmaps
[+] Cleaning cluster
[+] Preparing persistent-configuration-with-configmaps
[+] Setup complete
[+] Testing persistent-configuration-with-configmaps
configmap/nginx-base-conf created
configmap/index-html-zork created
configmap/nineteen-eighty-four created
pod/nginx-configured created
pod/nginx-configured condition met
NAME               READY   STATUS    RESTARTS   AGE
nginx-configured   1/1     Running   0          1s
[+] Test complete

Additional issue - teardown isn't cleaning up configmaps

student@bchd:~/git/kubernetes-the-alta3-way$ tl persistent-configuration-with-configmaps
[+] Cleaning cluster
[+] Preparing persistent-configuration-with-configmaps
[+] Setup complete
[+] Testing persistent-configuration-with-configmaps
error: failed to create configmap: configmaps "nginx-base-conf" already exists
error: failed to create configmap: configmaps "index-html-zork" already exists
error: failed to create configmap: configmaps "nineteen-eighty-four" already exists
pod/nginx-configured created
pod/nginx-configured condition met
NAME               READY   STATUS    RESTARTS   AGE
nginx-configured   1/1     Running   0          1s
[+] Test complete

fixed in https://github.com/alta3/kubernetes-the-alta3-way/commit/61256a4eb0abccc2b1e3a0f1dad6552e22d2d96f

Originally posted by @bryfry in https://github.com/alta3/kubernetes-the-alta3-way/issues/26#issuecomment-1347686681