altack / nx-bundlefy

Nx executor to ensure that all the buildable dependencies of a publishable library are part of the final bundle
MIT License
8 stars 7 forks source link

Support for nx 15.x.x #5

Open kborzecki opened 1 year ago

kborzecki commented 1 year ago

Hello, first of all - thank you for that custom executor. I do not understand why this is not an official feature of Nx.

I tried to use it in my nx 15 repository so I installed version 0.0.2. Unfortunately it did not work out of the box, because of the import in line 15:

import { calculateProjectDependencies } from '@nx/js/src/utils/buildable-libs-utils';

I got it to work by installing @nx/js@^16.0.0, but I'd prefer to use @nrwl/js@^15.0.0.

Could I kindly ask you to:

  1. Create 15.0.x branch from an earlier commit with proper nx 15 support
  2. Add devDependencies to package.json
  3. Fix peerDependencies by replacing >= with ^
  4. Release 15.0.0 version of your executor

I have those changes on my local environment. If you'd like, you could add me as a contributor so I could push those changes. If not, I'd be greatful if you could implement my suggestions.

wall-street-dev commented 1 year ago

@kborzecki Hey there! Sorry for the delay :D Don't know if you still need the v15 support, but here it's npm i @altack/nx-bundlefy@0.15.0 Will keep the issue open until a recieve your green light

Clindbergh commented 11 months ago

Ideally there would also be support for nx 17 😄 . Thanks!