search

altair-viz / jupyterlab_voyager

JupyterLab extension visualize data with Voyager
BSD 3-Clause "New" or "Revised" License
298 stars 35 forks source link

Add Integration Testing #21

Closed saulshanabrook closed 6 years ago

saulshanabrook commented 6 years ago

We should add some integration testing to verify that this extension works properly. They should run in (at least one) real browser and verify the existing behavior.

saulshanabrook commented 6 years ago

It would be nice to be able to run them in CI and also locally with (and without?) Docker. I have had good luck with pytest + pytest selenium, but that would add a Python dependency for developing this project. Not a problem with Docker, but without makes it a bit more troublesome.

I have never used Cypress, but it is appealing because it doesn't use the selenium/wedbriver stack (which I have often found to be unreliable), but built more directly on specific browser automation engines.

I think I will try that out, because it is an all-in-one solution and doesn't require Python.

saulshanabrook commented 6 years ago

I am trying to get Cypress running in Docker, so that I can have it and chrome in a separate container from our dependencies, but it doesn't seem to work with their prebuilt container.

saulshanabrook commented 6 years ago

Resolved that problem.