altair-viz / jupyterlab_voyager

JupyterLab extension visualize data with Voyager
BSD 3-Clause "New" or "Revised" License
298 stars 35 forks source link

Fix mybinder from having conflicting dependencies #66

Closed playermanny2 closed 5 years ago

playermanny2 commented 5 years ago

Dockerfile currently uses jupyter/minimal-notebook:c54800018c2c to build the extension on top of. This image is over a year old, and causes dependency conflicts.

This should be updated to a later or latest minimal-notebook image in order to have an acceptable jupyterlab version.

Conflicting Dependencies:
JupyterLab              Extension            Package
>=0.15.2-0 <0.16.0-0    >=0.19.1-0 <0.20.0-0 @jupyterlab/application
>=0.15.2-0 <0.16.0-0    >=0.19.1-0 <0.20.0-0 @jupyterlab/apputils
>=0.15.2-0 <0.16.0-0    >=0.19.1-0 <0.20.0-0 @jupyterlab/console
>=1.0.4-0 <2.0.0-0      >=2.1.4-0 <3.0.0-0   @jupyterlab/coreutils
>=0.15.2-0 <0.16.0-0    >=0.19.1-0 <0.20.0-0 @jupyterlab/docmanager
>=0.15.2-0 <0.16.0-0    >=0.19.3-0 <0.20.0-0 @jupyterlab/filebrowser
>=0.15.2-0 <0.16.0-0    >=0.19.2-0 <0.20.0-0 @jupyterlab/notebook
>=0.15.2-0 <0.16.0-0    >=0.19.1-0 <0.20.0-0 @jupyterlab/rendermime

Acceptance Criteria:

  1. jupyterlab_voyager mybinder build works properly
saulshanabrook commented 5 years ago

Sounds good to me!

playermanny2 commented 5 years ago

Fixed by https://github.com/altair-viz/jupyterlab_voyager/pull/67