Address Dockerfile pulling from latest minimal notebook and building … - Githubissues

altair-viz / jupyterlab_voyager

JupyterLab extension visualize data with Voyager

BSD 3-Clause "New" or "Revised" License

298 stars 35 forks source link

Address Dockerfile pulling from latest minimal notebook and building … #67

Closed playermanny2 closed 5 years ago

playermanny2 commented 5 years ago

This PR addresses updates to Dockerfile to build correctly and allow running of container with extension installed. This should allow mybinder to work properly.

Changes include

Pulling from latest minimal-notebook image
removing --no-build tag on jupyter link, so that it builds inside docker file, not on user request after running the image.

Issues Addressed: https://github.com/altair-viz/jupyterlab_voyager/issues/66 https://github.com/altair-viz/jupyterlab_voyager/issues/61