search

altair-viz / jupyterlab_voyager

JupyterLab extension visualize data with Voyager
BSD 3-Clause "New" or "Revised" License
298 stars 35 forks source link

Travis Build Failing #70

Open playermanny2 opened 5 years ago

playermanny2 commented 5 years ago

Currently, the travis build fails due to cypress integration test failing (opening_files.js). Specifically one part of the test fails when testing 'Open With -> Voyager'.

This is a known issue due to a disconnect between jupyterlab expecting native click events, while cypress triggers the context menu not via native events. There are milestones for both Jupyterlab and Cypress in order to address this disconnection, but there's no real date in mind for the feature update. More info on the issue can be followed here

This also can hinder writing tests for future features...I think there are two options here

  1. Wait on the issue to be corrected from either the jupyerlab side or cypress side
  2. Utilize another testing framework (potentially jest)

@saulshanabrook

saulshanabrook commented 5 years ago

@playermanny2 I am happy with either approach. I am not actively looking into fixing the issue, so if you would like to switch to another testing approach I would support that!