search

altair-viz / jupyterlab_voyager

JupyterLab extension visualize data with Voyager
BSD 3-Clause "New" or "Revised" License
298 stars 35 forks source link

Skip 1.1.3 and support jupyterlab 1.1.4👍 #78

Open flight505 opened 4 years ago

flight505 commented 4 years ago

When I attempt to install I get an Error: An error occurred. ValueError: No version of jupyterlab_voyager could be found that is compatible with the current version of JupyterLab. However, it seems to support a new version of JupyterLab. Consider upgrading JupyterLab.

playermanny2 commented 4 years ago

sorry guys, been swamped with some other things so ihaven't had to chance to dig into updating the repo.

The weird thing is that I've been using a jupyter docker stack which has 1.1.3 and haven't had any problems with the voyager extension being built...i've been rebuilding everyday as well https://github.com/jupyter/docker-stacks/tree/master/pyspark-notebook

I still plan to look into this and see how we can get it up to par with 1.1.4 though, anyone's free to hop in and do a PR if i don't get to it before though

peterquirk commented 4 years ago

Just tried to install in 1,1,4 and got these errors: jupyter labextension install ./jupyterlab_voyager An error occured. ValueError: "jupyterlab_voyager@1.0.2" is not compatible with the current JupyterLab Conflicting Dependencies: JupyterLabExtension Package

=16.8.4 <16.9.0>=16.9.0 <17.0.0 react =16.8.4 <16.9.0>=16.9.0 <17.0.0 react-dom

bklaas commented 4 years ago

I have the same error.

We are running jupyter lab 1.1.4 in a shared jupyterhub environment. lab 1.2.0 just came out, but from what I'm seeing above I don't think that will help.

playermanny2 commented 4 years ago

Hey @saulshanabrook would you mind taking a look here?

I went ahead and downgraded the react and react-dom to 16.8.6 (Not sure why now it doesn't like the 17.x. version) but now there's some weird errors happening. The build succeeds but when jupyterlab actually trys to load the extension there's a runtime error happening

index.out.js:1439 TypeError: Cannot read property 'oneOfType' of undefined
    at Object.<anonymous> (lib-voyager.js:1)
    at t (lib-voyager.js:1)
    at Object.<anonymous> (lib-voyager.js:1)
    at t (lib-voyager.js:1)
    at Object.<anonymous> (lib-voyager.js:1)
    at t (lib-voyager.js:1)
    at Object.<anonymous> (lib-voyager.js:1)
    at t (lib-voyager.js:1)
    at Object.<anonymous> (lib-voyager.js:1)
    at t (lib-voyager.js:1)

Dug into it a little and looks like it's stemming from the datavoyager library and react proptypes api being changed to come from core react lib instead of it's own proptypes library.

If this is the case i'm not sure what we can do to get this package working without going upstream to the datavoyager library? It just seems odd that now it would start acting up...even when reverting to a previous working react and react-dom package

Screenshot from 2019-10-30 15-32-14

playermanny2 commented 4 years ago

sorry guys, been swamped with some other things so ihaven't had to chance to dig into updating the repo.

The weird thing is that I've been using a jupyter docker stack which has 1.1.3 and haven't had any problems with the voyager extension being built...i've been rebuilding everyday as well https://github.com/jupyter/docker-stacks/tree/master/pyspark-notebook

I still plan to look into this and see how we can get it up to par with 1.1.4 though, anyone's free to hop in and do a PR if i don't get to it before though

also realized even though i had a docker image for 1.1.3, i was downgrading jupyelab to 1.0.4, so this statement is wrong

bioinfornatics commented 4 years ago

I got the same problem with jupyterlab 1.1.4

falzberger commented 4 years ago

same problem for me with JLab 1.2.3. When manually setting the react and react-dom to versions ~16.8.4 (equal to the specification in JLab's package.json), voyager won't be available and I get the following error: grafik

Sanyam07 commented 4 years ago

Its been so long and i guess no solution came till now. I tried installing lab v2.0.1 , v1.1.4, v1.13, v1.1.0. None builds properly. All have the same error.

An error occured.
ValueError: 
"jupyterlab_voyager@1.0.2" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLabExtension        Package
>=16.8.4 <16.9.0>=16.9.0 <17.0.0 react
>=16.8.4 <16.9.0>=16.9.0 <17.0.0 react-dom
See the log file for details:  /tmp/jupyterlab-debug-tq87o3r0.log
ERROR: Service 'build' failed to build: The command '/bin/sh -c jupyter labextension link .' returned a non-zero code: 1

Is there any workaround or anything can be done to resolve??

ghost commented 3 years ago

@falzberger Forcing react 16 is not the right approach I believe, since upstream datavoyager uses 15. Perhaps we could get it to work by forcing react 15, but when I did that I wasn't able to get react-dom to load in jupyterlab 1.1. See https://github.com/altair-viz/jupyterlab_voyager/issues/82#issuecomment-811743066