search

altair-viz / jupyterlab_voyager

JupyterLab extension visualize data with Voyager
BSD 3-Clause "New" or "Revised" License
298 stars 35 forks source link

sass-loader compilation error #91

Closed ghost closed 3 years ago

ghost commented 3 years ago

When using the fork which purports to work with a new jupyterlab: https://github.com/arimorgan/jupyterlab_voyager/commit/a9dadff7a0c126451d341fedb6a8f43d9926624a

Products error during install:

    ERROR in ./node_modules/font-awesome-sass-loader/font-awesome-sass.config.js (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js!./node_modules/font-awesome-sass-loader/font-awesome-sass-styles.loader.js!./node_modules/font-awesome-sass-loader/font-awesome-sass.config.js)
    Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
    TypeError: this.getOptions is not a function
        at Object.loader (/usr/local/share/jupyter/lab/staging/node_modules/sass-loader/dist/index.js:25:24)

Seems that font-awesome-sass-loader@1.0.5 is being brought in by datavoyager 2.0.0-alpha.24 since it only specifies font-awesome-sass-loader@^1.0.3.

Anyone else come across this and addressed it?

ghost commented 3 years ago

Can be fixed by pinning sass-loader to 10.1.0 in the yarn.lock.

sass-loader@*:
  version "10.1.0"
  resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-10.1.0.tgz#1727fcc0c32ab3eb197cda61d78adf4e9174a4b3"
  integrity sha512-ZCKAlczLBbFd3aGAhowpYEy69Te3Z68cg8bnHHl6WnSCvnKpbM6pQrz957HWMa8LKVuhnD9uMplmMAHwGQtHeg==
  dependencies:
    klona "^2.0.4"
    loader-utils "^2.0.0"
    neo-async "^2.6.2"
    schema-utils "^3.0.0"
    semver "^7.3.2"