altair-viz / vega_datasets

A Python package for online & offline access to vega datasets
MIT License
173 stars 57 forks source link

Transition to v2 #39

Open eitanlees opened 4 years ago

eitanlees commented 4 years ago

The vega/vega-datasets repository recently released a major update. A few changes will need to be made to catch up. I just wanted to file this issue to get the ball rolling.

I can work on it and submit a PR when I get a bit of free time :)

eitanlees commented 4 years ago

Hey, I wanted to check back in about getting altair/vega_datasets up to date with vega/vega-datasets.

The merge of #42 seems to have caused a failing build, but I am unsure why? (It might just be a fluke?)

The current release on PyPI is version 0.8.

I am unsure if you want to release a version 0.9 with the addition of the CDN base url, and then later release a version 1.0 which would introduce some breaking changes.

PR #40 is the big one which would bring everything up to date. Currently there are a few merge conflicts which I can resolve once we have a plan.

I think @jakevdp is the only one who can do the PyPI release.

domoritz commented 4 years ago

It would be great to get this update in so that the examples on the Altair website work again (https://github.com/altair-viz/vega_datasets/issues/43).

eitanlees commented 4 years ago

I will work on the #40 and let you know when it's good to go

eitanlees commented 4 years ago

Alright, I revisited #40, rebased on mater, and cleaned things up. All tests are passing and I think everything should be good to go.

domoritz commented 4 years ago

Did you want to make a release for Vega datasets 1 with versioned CDN links (I can't check right now so excuse me if you've already done it).

eitanlees commented 4 years ago

We haven't done that yet. I think @jakevdp is the only one who can do a PyPI release, so that is up to him.

Seems like a good idea though. v0.9 would introduce the CDN links, and v1.0 would introduce breaking changes that would bring the packaged up to date.