altangent / ccxws

WebSocket client for 38 cryptocurrency exchanges
MIT License
617 stars 186 forks source link

Refactor Binance, BinanceUS and BinanceJE clients #162

Closed bmancini55 closed 4 years ago

bmancini55 commented 4 years ago

This is a rewrite of the Binance code to support the live subscribe and remove the custom client code that used URL-based subscriptions.

The changes include:

This issue resolves #161

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build a8efb43f-83c1-469e-91e9-6a1f83b69578


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/exchanges/binance-base.js 136 144 94.44%
<!-- Total: 208 216 96.3% -->
Files with Coverage Reduction New Missed Lines %
src/exchanges/gemini-client.js 1 89.87%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build a4f6ea7a-513c-4341-866c-b90af47b062f: 4.9%
Covered Lines: 2608
Relevant Lines: 2772

💛 - Coveralls