altdesktop / i3ipc-glib

A C interface library to i3wm
GNU General Public License v3.0
104 stars 18 forks source link

change type of window id to uint #9

Closed cornerman closed 8 years ago

cornerman commented 8 years ago

As mentioned in https://github.com/acrisci/i3ipc-glib/issues/8, this changes the type of the window id to unsigned int. This corresponds to the definition of the window id in i3 which is uint32_t.

acrisci commented 8 years ago

I'll take a look.

If you have any other ideas for breaking changes, now is the time because I'll be bumping the major version soon.

cornerman commented 8 years ago

Hmm, I have looked through the definition of i3's Con struct and the definition of i3ipcCon. There are only a few differences in the types (not problematic though):

Especially, the last point is important to me. It would be great if there was a way to find out whether a container is in output or global fullscreen-mode, because this is currently not possible. Though, I am not sure whether changing the type of fullscreen-mode would be the best way for users of this library or whether introducing a second property would suffice.

acrisci commented 8 years ago

I'll look into making those type changes.

As for fullscreen_mode, I think I might want to turn that into an enum. There are some others that would be good as enums as well, such as layout, orientation, and type.

acrisci commented 8 years ago

i3#2014 is going to require breakage as well.