`Con` classes are missing the `shell` attribute as mentioned in the sway ipc spec

altdesktop / i3ipc-python

🐍 An improved Python library to control i3wm and sway.

http://i3ipc-python.readthedocs.io

BSD 3-Clause "New" or "Revised" License

851 stars 109 forks source link

`Con` classes are missing the `shell` attribute as mentioned in the sway ipc spec #172

Closed rifazn closed 3 years ago

rifazn commented 3 years ago

The Con class is missing a sway-only attribute, shell, which is included in the sway-ipc specification.

Should this be included for compatibility with sway?

There are other sway-only attributes included within the library (app_id, pid, representation and visible) so this attribute is probably missing here.

Sway-ipc spec: https://man.archlinux.org/man/sway-ipc.7.en#4._GET_TREE

acrisci commented 3 years ago

Yeah go ahead and do a PR for it.

rifazn commented 3 years ago

PR: #173