search

altdesktop / python-dbus-next

🚌 The next great DBus library for Python with asyncio support
https://python-dbus-next.readthedocs.io/en/latest/
MIT License
187 stars 59 forks source link

Check for mismatched signal handler arg annotation #103

Closed msftcangoblowm closed 2 years ago

msftcangoblowm commented 2 years ago

Both test and fix provided

Introduces a new Exception, AnnotationMismatchError

This Exception occurs only when:

The point is to be informative (to Client developer), not to be strict.

A Client developer can be mistaken on what arg type to expect. The Exception message will help the Client developer pinpoint exactly which signal handler, arg, and what is the correct annotation for that arg. So as to quickly resolve the mismatch.

msftcangoblowm commented 2 years ago

Not sure why the test is not being accepted or what is the source of the build fail. Please advise.

Not sure why 0f89ab6 and 11ad1c1 are included in this pull request. That isn't intended.

There is no provided documentation explanation concerning AnnotationMismatchError. Figured that can be done later.

Wanted this pull request to go thru a review process

acrisci commented 2 years ago

I'm not going to merge this because I don't think it's useful and I don't want to maintain it.