altence / lightence-ant-design-react-template

Free and easy-to-use admin template based on React 17+

https://altence.com/lightence-landing

MIT License

994 stars 251 forks source link

Fix: Ant Menu Deprecated Warnings #243

Closed UtkarshM-hub closed 1 year ago

UtkarshM-hub commented 2 years ago

Description

Fixes #237

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

by running the project locally
making sure that the routes are working
making sure that the issue is resolved by checking console logs

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

UtkarshM-hub commented 2 years ago

@alexanderrudnik @Findmitrey @AlexKarmaz

leineveber commented 1 year ago

Hello @UtkarshM-hub,

Thanks for taking a part in the development.

We adhere to certain code quality throughout the project. Those Ant Menus should be fixed everywhere we use them and not only in the sidebar. Also, looks like translation is broken, please use translation functions

UtkarshM-hub commented 1 year ago

hey @leineveber, I tried fixing it but I think I am having problems on my side and not able to pull that off

leineveber commented 1 year ago

Closing due to inactivity