search

altence / lightence-ant-design-react-template

Free and easy-to-use admin template based on React 17+
https://altence.com/lightence-landing
MIT License
1.01k stars 258 forks source link

Why do `main` and `v2.0.0` diverge? #253

Closed nvmnghia closed 1 year ago

nvmnghia commented 1 year ago

This is not a bug report, just a question. My code works in main, but not in v2.0.0, maybe due to some babel upgrade. After bisecting, I found out that main doesn't contain v2.0.0 at all. Why is this the case? Which one should I use?

leineveber commented 1 year ago

What do you mean by main doesn't contain 2.0.0? I see that main includes 2.0.0 by commits + a few more commits.

Please use main branch if you have problems with 2.0.0

nvmnghia commented 1 year ago

@leineveber this is the v2 commit. Github says it's not contained in any branch.

leineveber commented 1 year ago

@nvmnghia I see in main commits that its contained there

nvmnghia commented 1 year ago

Oh I see. Tip of v2 and main are 2 different commits, though they may have the same content. Running

git log | grep $(git rev-list -n 1 tags/v2.0.0)

on main also yields nothing. Did you rebase v2 on top of somewhere in main? Anyway I still think this is weird.

leineveber commented 1 year ago

@nvmnghia Just made a new release - 2.1.0. Please use it instead of 2.0.0