search

altera2015 / usbserial

Flutter Android USB Serial plugin
BSD 3-Clause "New" or "Revised" License
119 stars 83 forks source link

add maxLen and stripTerminator args to terminated Transaction #87

Closed EParisot closed 10 months ago

EParisot commented 10 months ago

Ok I think I should do it again but from the new commit after previous PR and rework a bit... I already tried it but it didn't work with my current project... got to fix this gradle issue on my side too...

EParisot commented 10 months ago

ok this should be better, I added the optional arge on both Transformers also. Can you re-run the merge ? or should I create another PR ?

altera2015 commented 10 months ago

ok this should be better, I added the optional arge on both Transformers also. Can you re-run the merge ? or should I create another PR ?

Hmm still failing some flutter checks :(

EParisot commented 10 months ago

I can assume the semicolumn issues have been introduced by my PR but I don't know about the rest thought, did the PR 77 passed the same tests ?

EParisot commented 10 months ago

Also, I cant manage to make it works with my code, app crash as soon as I plug or unplug my usb device. SDK 33 seems to have a bug regarding the getParcelableExtra : https://issuetracker.google.com/issues/240585930 I will have to revert to previous version on my fork for now...

altera2015 commented 10 months ago

Not sure what is happening here. The upgrade to dart 3 likely caused these issues. I don't have time to dive in but this article does explain how to get passed them:

https://medium.com/@reginfell/flutter-dart-strong-mode-fd936bb8551f

altera2015 commented 10 months ago

I'll revert the previous MR.

altera2015 commented 10 months ago

I've reverted 77 and fixed the warnings, please rebase your PR on master.

EParisot commented 10 months ago

Yes multiple problems I think, I did the same on my fork thanks

EParisot commented 10 months ago

I just fixed the (formating) conflics, this works on my side

EParisot commented 10 months ago

sry about that , I my Java env is not up to date