altercation / solarized

precision color scheme for multiple applications (terminal, vim, etc.) with both dark/light modes
http://ethanschoonover.com/solarized
MIT License
15.82k stars 3.52k forks source link

iTerm 2: Solarized Dark, zsh: Color of the comments is same as the background #351

Closed icyflame closed 8 years ago

icyflame commented 8 years ago

I am not sure why this is happening. has this problem been faced by someone before? If so, what was the fix?

zeorin commented 8 years ago

I have this same problem. I assume you're using zsh-syntax-highilghting plugin? It only happens with the Solarized Dark colour scheme?

Then it's this issue: https://github.com/altercation/solarized/issues/220. Basically, the brblack ANSI color in Solarized Dark is the same as the background color.

icyflame commented 8 years ago

@zeorin Absolutely, I have since switched to Solarized Light ( ❤️ ) and liked that as well. But I would love to get back to Solarized Dark.

That issue is pretty dense in terms of discussion, and it's name is also slightly misleading. (It didn't turn up in the searches I did before posting this issue.)

Closing this in favour of #220 .

icyflame commented 8 years ago

@zeorin Checked out the discussion, and found out about base16. It's a huge repository, and it's solarized dark theme works very well. Switched to that: https://raw.githubusercontent.com/chriskempson/base16-iterm2/master/base16-solarized.dark.256.itermcolors

in case you are interested.

petern-sc commented 4 years ago

Seconded, the repo above is deprecated, but using the newer fork colours are showing as expected https://github.com/martinlindhe/base16-iterm2/tree/master/itermcolors