search

altercation / solarized

precision color scheme for multiple applications (terminal, vim, etc.) with both dark/light modes
http://ethanschoonover.com/solarized
MIT License
15.82k stars 3.52k forks source link

xresources light (commented out) broken #382

Open egmontkob opened 6 years ago

egmontkob commented 6 years ago

xresources/solarized defines the dark color scheme correctly, and contains an incorrect definition for the light one in comments.

It reverses the order of base03..base3. According to the section "The Values" on Solarized homepage all the 16 indices have a fixed RGB, there's no shuffling. According to "Usage & Development" there, it's the responsibility of applications to reverse the order (e.g. wherever they'd pick base01 on dark background, pick base1 on light background).

The upstream location https://github.com/solarized/xresources seems to have this fixed.

egmontkob commented 6 years ago

(Nitpicking: let's also mention the silly order of color9 followed by color8.)