SignColumn highlighting could do with some lovin'

[saj]

Solarized's default sign highlighting is a little harsh on the eyes: I see purple on white with background=dark.

Adding s:bg_base02 was good enough for me:

diff --git a/colors/solarized.vim b/colors/solarized.vim
index 70f5223..0c78d59 100644
--- a/colors/solarized.vim
+++ b/colors/solarized.vim
@@ -654,7 +654,7 @@ exe "hi! DiffDelete"     .s:fmt_none   .s:fg_red    .s:bg_base02
 exe "hi! DiffText"       .s:fmt_none   .s:fg_blue   .s:bg_base02 .s:sp_blue
     endif
 endif
-exe "hi! SignColumn"     .s:fmt_none   .s:fg_base0
+exe "hi! SignColumn"     .s:fmt_none   .s:fg_base0  .s:bg_base02
 exe "hi! Conceal"        .s:fmt_none   .s:fg_blue   .s:bg_none
 exe "hi! SpellBad"       .s:fmt_curl   .s:fg_none   .s:bg_none    .s:sp_red
 exe "hi! SpellCap"       .s:fmt_curl   .s:fg_none   .s:bg_none    .s:sp_violet

Thanks!

[jwhitley]

+1 This is particularly egregious when Solarized is used with @airblade's vim-gitgutter.

[jayekub]

+1

[ZeroKnight]

:+1:

[adolfoabegg]

+1

[lkraav]

+1 .s:bg_base02 works perfectly

[csierra]

+1 works great with vim-gitgutter

[airblade]

Works for me (vim-gitgutter author)!

[mechanicles]

:+1:

[neiled]

:+1:

[jrhorn424]

:+1:

[shuangwu]

:+1:

[flybayer]

:+1:

[vitalk]

:+1:

[jacob-keller]

Definitely +1 for me as well.