Closed GoogleCodeExporter closed 9 years ago
I only planned the behavior of Contour-fill tool for a single-pixel outline.
The fact that the mouse still shows the color brush is rather a bug that I
wasn't able to fix and left this way - 'just hit Del to move the brush out of
the way'.
Can you confirm that the need is to contour-fill with 'thick' monochrome
brushes ? I guess the (xor) preview would need to faithfully represent all the
affected pixels while you're tracing the outline.
With colour brushes... it would be more ugly (dragged brushover on outline,
flat fill in the middle) so I don't know if this is useful.
Original comment by yrizoud
on 26 Sep 2012 at 2:34
That's not it.
The idea is :
* Draw a line: behave as we do right now
* Draw a single pixel: this is not a contour, so, put the brush instead
This way you can both paste the brush, and contour-fill some areas, without
having to constantly swap tools.
Original comment by pulkoma...@gmail.com
on 26 Sep 2012 at 7:40
Yes that is in fact what I meant, sorry for not being clear.
Original comment by ilija.melentijevic
on 26 Sep 2012 at 10:40
Looks like a lot of complexity would be avoided if the Contour fill tool had
its own button.
Note that at the moment, you can already use the setting "Editing/Auto
discontinuous" to switch to 'Discontinuous freehand' when you grab a brush. But
when you're done with the brush, you still need to right-click the button 3
times to re-select Contour fill :-/
Original comment by yrizoud
on 27 Sep 2012 at 9:12
Oh I totally missed the editing/auto discontinuous checkbox! Will look for it
and see how that works.
I assume there's no point in adding one button unless we take a look at all the
buttons and decide that things could be arranged better.
Perhaps cycle-button functions can be assigned individual keyboard shortcuts,
so they're still on the same button but you can press one shrtcut instead of
having to go shift-D 3 times.
Original comment by ilija.melentijevic
on 27 Sep 2012 at 10:03
"continuous freehand" already has its own shortcut, it's not mentioned in the
button's help, but it's in the complete list (ctrl-d). From the 3 historical
freehand modes, it's the only one which had an explicit shortcut, so I suppose
the authors always used 'auto discontinuous' option, and then only needed one
shortcut to switch back to continuous. The third freehand mode's usefulness
seems questionable, by the way.
Original comment by yrizoud
on 27 Sep 2012 at 1:58
I can only assume that mode is for when you want to precisely place a brush
using a touchpad.
Contourfill is only useful in 'pen' mode, and singleclick is only useful in
brush mode.
How about make them exclusive? If in contourfill, when a brush is picked, it
will autoswitch to 'third mode'. When you 'drop' the brush, it will go back to
contour. Other pen modes will stay on when entering brush mode. Does that makes
sense?
Original comment by ilija.melentijevic
on 27 Sep 2012 at 2:17
that's a bit complicated to do, we have to remember you where in contour fill
mode when grabbing the brush. and you have to remember it as well, or the
switch to contour fill may be unexpected.
For easier reaching of the different drawing modes, what I had in mind is add a
right click popup menu (just like on magnify), with all the modes inside, so
you can easily grab one. Since the popup for magnify is working ok, it
shouldn't be too hard to get it working on this as well. Signle right click
wouldstill switch to the next drawing mode.
Original comment by pulkoma...@gmail.com
on 28 Sep 2012 at 6:36
You wouldn't have to remember anything:
-if you pick upa a brush in cfill mode, go to singleclick mode
-if dropping a brush in singleclick, go to cfill
other 2 modes stay the same with or witout a brush
Never mind, the popup menu is a better idea.
Original comment by ilija.melentijevic
on 29 Sep 2012 at 7:52
Fixed in r2113.
Original comment by pulkoma...@gmail.com
on 4 Mar 2015 at 2:33
Original issue reported on code.google.com by
ilija.melentijevic
on 26 Sep 2012 at 12:38