search

alterm4nn / ChronoZoom

ChronoZoom is an interactive timeline for all of history.
http://www.chronozoom.com
156 stars 125 forks source link

Author: Deletion of timelines doesn't actually deletes timelines. #1141

Open mkalygin opened 10 years ago

mkalygin commented 10 years ago

Example collection: http://test.chronozoom.com/mkalygin Example API GET call for the content: http://test.chronozoom.com/api/gettimelines?supercollection=mkalygin&collection=mkalygin&start=-50000000000&end=9999

There is the only timeline in this collection, all children timelines were deleted by the author. However in the API call results we can see all previous timelines that were existing before, e.g.:

{ "__type": "TimelineRaw:#Chronozoom.Entities", "Height": null, "Regime": "Cosmos", "end": 0.0000000, "exhibits": [], "id": "7c046a1e-0d5f-45ae-a1f4-57327ac0e2dc", "start": 0.0000000, "timelines": null, "title": "Timeline Title", "ParentTimelineId": "bad5c71c-1e76-492d-ada4-a1ddec498aac" }

The deletion of timelines actually sets a width of timelines to zero, what potentially will cause slow performance of requests for the content.

M3tan3rd commented 10 years ago

I changed this issue type to minor even though it is nasty. The "Minor" label is for user impact - there is none unless vast amounts of data is forgotten in the system (Michael may have more information as he was worried about resulting poor performance)