search

alterm4nn / ChronoZoom

ChronoZoom is an interactive timeline for all of history.
http://www.chronozoom.com
156 stars 125 forks source link

Fix for Re-Opening Customize Collection Pane #1397

Closed NeilCresswell closed 9 years ago

NeilCresswell commented 9 years ago

Previously when you opened the customize collection pane, it would open fine the first time but elements would appear to be missing a second time (without a refresh) and it would freeze on the third attempt.. This was due to a JS initialization call (which occurs on each open) failing as the item being initialized had already been initialized the first time. Added check to see if already initialized which resolves issue.

NeilCresswell commented 9 years ago

Given that #1397 wasn't built off of #1396, and both had JS changes, a build will also be needed in order to generate a new merged JS file.

alterm4nn commented 9 years ago

@NeilCresswell I've rechecked again - git's merge worked perfectly :-)

NeilCresswell commented 9 years ago

Great. Thanks for checking. :) Was just erring on the side of caution.