CleanCode: Timescale: method CosmosTickSource.getMarkerLabel has unused if

[a-chumagin]

Observed:

   this.getMarkerLabel = function (range, time) {
            var text;
            this.getRegime(range.min, range.max);
            var n = Math.max(Math.floor(Math.log(this.delta * Math.pow(10, this.beta) / this.level) * this.log10), -4) - 1;
            if(n > 20) {
                n = 20;
            }
            if(n < -20) {
                n = -20;
            }
            if(n < 0) {
                text = (new Number(-time / this.level)).toFixed(-n);
            } else {
                text = (new Number(-time / this.level)).toFixed(n);
            }
            text += " " + this.regime;
            return text;
        };

1. if(n < -20) - Condition never be true, because n is more than -3 always. See var n = Math.max(Math.floor(Math.log(this.delta * Math.pow(10, this.beta) / this.level) * this.log10), -4) - 1
2. function

           if(n < 0) {
                text = (new Number(-time / this.level)).toFixed(-n);
            } else {
                text = (new Number(-time / this.level)).toFixed(n);
            }

Change to text = (-time/this.level).toFixed(Math.abs[n])

1. "text", "n" - are not clear names. Use more intelligible

Link to trello card: https://trello.com/c/P4QjkuQJ

[GiorgiyLutidze]

fixed in https://github.com/GiorgiyLutidze/ChronoZoom/commit/e254c44188d50d03d02f5be2ed4a0095adaee21e

[a-chumagin]

@GiorgiyLutidze I cannot close bug. There is not unit tests for changes.

[a-chumagin]

There is no unit tests

[alterm4nn]

Code changed significantly.

[a-chumagin]

closed