search

alterm4nn / ChronoZoom

ChronoZoom is an interactive timeline for all of history.
http://www.chronozoom.com
160 stars 127 forks source link

CleanCode: Items data are not validated on server side #242

Closed a-chumagin closed 11 years ago

a-chumagin commented 11 years ago
  1. Send put request to server with incorrects data e.x {"ParentTimelineId":"e9c36847-7a45-4bfe-a15a-75c08605ccd7","FromYear":-20700000000,"ToYear":3000,"title":"","Regime":"Cosmos"}
  2. Open Chronozoom

Observed: Timeline gas been created Expected: Server returns error. Timeline is not created 2013-04-19_1932

charuch commented 11 years ago

The data being passed in looks valid. Which part of it is invalid?

charuch commented 11 years ago

Start date in outside of the bounds of the parent timeline. Validation needs to be added to ensure start and end year lie within the bounds of the parent timeline.

charuch commented 11 years ago

Is the start date in outside of the bounds of the parent timeline or is the issue being reported something else? If required I can add validation needs to ensure start and end year lie within the bounds of the parent timeline.

charuch commented 11 years ago

Code review completed and approved at http://mrccodereview.cloudapp.net/ui#review:id=1158

a-chumagin commented 11 years ago

Bug with date is fixed. Bug woth empty title is not fixed https://github.com/alterm4nn/ChronoZoom/issues/361