alterm4nn / ChronoZoom

ChronoZoom is an interactive timeline for all of history.
http://www.chronozoom.com
160 stars 127 forks source link

CleanCode: Misc: Over 1000 warnings running jslint #57

Closed JayBeavers closed 11 years ago

JayBeavers commented 11 years ago

1) Install http://visualstudiogallery.msdn.microsoft.com/1a417c37-4d6f-43ca-b753-6ea6eb5041fd

2) Build

3) Uh-oh.

alterm4nn commented 11 years ago

Most of them related to jQuery and rx though. Other problem is that current code is TypeScript-generated.

Suggest closing this.

JayBeavers commented 11 years ago

We have old versions of jQuery and rx and most of the errors are coming from a very old version of jQuery. We have the ability to upgrade these which will fix these violations.

Let's leave this open and get the work done. JSLint finds very real bugs, today these bugs are hidden behind a lot of noise from the old libraries.

JayBeavers commented 11 years ago

? JSLint now off the table?

alterm4nn commented 11 years ago

Yes, feature cut + many warnings come from TypeScript compiler.