codecov[bot]
commented
4 years ago Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@19acb46). Click here to learn what that means. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 94.74%
=========================================
Files ? 10
Lines ? 970
Branches ? 0
=========================================
Hits ? 919
Misses ? 51
Partials ? 0 | Impacted Files | Coverage Δ | |
|---|---|---|
| autonormalize/dfd.py | 98.10% <100.00%> (ø) |
|
| autonormalize/normalize.py | 98.19% <100.00%> (ø) |
|
| autonormalize/tests/test_dfd.py | 91.17% <100.00%> (ø) |
|
| autonormalize/tests/test_normalize.py | 100.00% <100.00%> (ø) |
|
| autonormalize/__init__.py | 100.00% <0.00%> (ø) |
|
| autonormalize/pyspy2.py | 0.00% <0.00%> (ø) |
|
| autonormalize/classes.py | 95.07% <0.00%> (ø) |
|
| autonormalize/autonormalize.py | 70.45% <0.00%> (ø) |
|
| autonormalize/tests/test_example.py | 100.00% <0.00%> (ø) |
|
| ... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 19acb46...4fa5693. Read the comment docs.
CLAassistant
This PR fixes two issues that were identified when trying to replicate the error described in Issue #19
The first change addresses a problem that resulted by trying to do an
==comparison betweennanvalues.The second change fixes an issue that can happen causing a column that is needed in other relationships to be dropped from an entity when
make_indexesis executed.Two additional tests were added to cover these scenarios.
Also, note, while these issues were discovered when testing for Issue #19, that specific error was not reproduced and it is unknown whether these changes will resolve that issue or not.