alteryx / autonormalize

python library for automated dataset normalization
https://blog.featurelabs.com/automatic-dataset-normalization-for-feature-engineering-in-python/
BSD 3-Clause "New" or "Revised" License
109 stars 16 forks source link

Fix non-deterministic column names created by make_indexes #25

Closed thehomebrewnerd closed 4 years ago

thehomebrewnerd commented 4 years ago

Added sort call to make sure new column names are always created the same.

Updated test_make_indexes to check that column names are returned with the expected names.

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   94.06%   94.10%   +0.03%     
==========================================
  Files          10       10              
  Lines         927      933       +6     
==========================================
+ Hits          872      878       +6     
  Misses         55       55              
Impacted Files Coverage Δ
autonormalize/classes.py 95.14% <100.00%> (+0.07%) :arrow_up:
autonormalize/tests/test_normalize.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 764a652...f1d4cfe. Read the comment docs.