Update requirements.txt to remove nbconvert and nbsphinx, and fix category_encoders to 2.0.0

alteryx / categorical_encoding

Repository for the research and implementation of categorical encoding into a Featuretools-compatible Python library

BSD 3-Clause "New" or "Revised" License

50 stars 15 forks source link

Update requirements.txt to remove nbconvert and nbsphinx, and fix category_encoders to 2.0.0 #6

Closed gsheni closed 4 years ago

gsheni commented 4 years ago

Remove nbconvert, and nbsphinx from the requirements.txt
- jupyter installs latest nbconvert, which requires on nbsphinx.
- Transitive relationship means that we should just rely on jupyter, this will resolve to install the correct version of nbconvert and nbsphinx
Fix category_encoders to 2.0.0

rwedge commented 4 years ago

I think we should confirm which dependencies are necessary to use the library and which are used to run through the demo notebooks. I don't think demo-specific dependencies should be in the base requirements for the library.

rwedge commented 4 years ago

Can you mention installing demo-requirements.txt in the readme when it talks about looking at the guides?

gsheni commented 4 years ago

Can you mention installing demo-requirements.txt in the readme when it talks about looking at the guides?

Fixed.

CLAassistant commented 4 years ago

All committers have signed the CLA.