alteryx / compose

A machine learning tool for automated prediction engineering. It allows you to easily structure prediction problems and generate labels for supervised learning.
https://compose.alteryx.com
BSD 3-Clause "New" or "Revised" License
497 stars 46 forks source link

Rename target_dataframe_name parameter to target_dataframe_index #348

Closed thehomebrewnerd closed 1 year ago

thehomebrewnerd commented 1 year ago

Compose previously used the terminology target_entity to refer to the target column. When Featuretools updated to change target_entity to target_dataframe_name, a corresponding change was made in Compose in PR #241.

I don't believe this change should have been made. In Compose the target_entity actually refers to the name of a column in a dataframe, not the name of a ft.Entity object. The current parameter name is confusing and should be changed to be more clear.

Suggestion: rename the target_dataframe_name parameter to target_dataframe_index.