alteryx / featuretools

An open source python library for automated feature engineering
https://www.featuretools.com
BSD 3-Clause "New" or "Revised" License
7.28k stars 878 forks source link

Fix bug in PercentTrue primitive #2627

Closed thehomebrewnerd closed 1 year ago

thehomebrewnerd commented 1 year ago

Pull Request Description

Fix bug with default value in PercentTrue primitive

Closes #2625

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f98704f) 99.47% compared to head (4c774c2) 99.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2627 +/- ## ======================================= Coverage 99.47% 99.47% ======================================= Files 403 404 +1 Lines 24201 24214 +13 ======================================= + Hits 24074 24087 +13 Misses 127 127 ``` | [Files](https://app.codecov.io/gh/alteryx/featuretools/pull/2627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alteryx) | Coverage Δ | | |---|---|---| | [...ls/primitives/standard/aggregation/percent\_true.py](https://app.codecov.io/gh/alteryx/featuretools/pull/2627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alteryx#diff-ZmVhdHVyZXRvb2xzL3ByaW1pdGl2ZXMvc3RhbmRhcmQvYWdncmVnYXRpb24vcGVyY2VudF90cnVlLnB5) | `100.00% <100.00%> (ø)` | | | [...s/aggregation\_primitive\_tests/test\_percent\_true.py](https://app.codecov.io/gh/alteryx/featuretools/pull/2627?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=alteryx#diff-ZmVhdHVyZXRvb2xzL3Rlc3RzL3ByaW1pdGl2ZV90ZXN0cy9hZ2dyZWdhdGlvbl9wcmltaXRpdmVfdGVzdHMvdGVzdF9wZXJjZW50X3RydWUucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.