Closed sbadithe closed 1 year ago
Merging #1733 (df2e357) into main (bf63dd3) will decrease coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1733 +/- ##
==========================================
- Coverage 98.76% 98.75% -0.01%
==========================================
Files 98 98
Lines 11942 11954 +12
==========================================
+ Hits 11794 11805 +11
- Misses 148 149 +1
Impacted Files | Coverage Δ | |
---|---|---|
woodwork/tests/type_system/test_ltype_inference.py | 100.00% <ø> (ø) |
|
woodwork/tests/type_system/test_type_system.py | 100.00% <100.00%> (ø) |
|
woodwork/type_sys/inference_functions.py | 99.24% <100.00%> (-0.76%) |
:arrow_down: |
woodwork/type_sys/type_system.py | 100.00% <100.00%> (ø) |
Partially fixes #1033
Currently, the inference function for the Boolean logical type calls the inference functions for BooleanNullable. However, considering that the Boolean is a child of its corresponding Nullable type, we know that the Nullable inference function must have already been computed by the time we are performing Boolean inference. By caching the result of the BooleanNullable inference, we can avoid recomputing its result.
We can apply this same argument to Integer/IntegerNullable to speed up performance.
Preliminary performance testing points to a ~84% speed up on
boolean_heavy
data and a ~78% speed up onnumeric_heavy
data.