search

alterzero / RBPN-PyTorch

The project is an official implement of our CVPR2019 paper "Recurrent Back-Projection Network for Video Super-Resolution"
https://alterzero.github.io/projects/RBPN.html
MIT License
449 stars 104 forks source link

Bug in dataset.py? #6

Closed coolKeen closed 5 years ago

coolKeen commented 5 years ago

Hi, thanks for your nice code! In line 53 of dataset.py, I think the code should be " if nFrames%2 == 0: seq = [x for x in range(-tt,tt) if x!=0] # or seq = [x for x in range(-tt+1,tt+1) if x!=0] else: seq = [x for x in range(-tt,tt+1) if x!=0] " because when nFrames is an even number, " seq = [x for x in range(-tt,tt+1) if x!=0]" will make the number of neigbor equal to nFrames instead of nFrames-1. You can try running the command "python main.py --other_dataset True --nFrames 6".

alterzero commented 5 years ago

Thank you, I just revised that part.

musicrainie commented 5 years ago

And so, for the same reason, should the following line https://github.com/alterzero/RBPN-PyTorch/blob/08757cb463a46a4dccb7f28d8bbf1ef8e21ea2a6/dataset.py#L74 be changed to "seq = [x+4 for x in range(-tt, tt+(0 if (nFrames % 2 ==0) else 1)) if x!=0]" or something?