search

althea-net / serde-rlp

Ethereum's RLP encoding implemented as a Serde data format
Apache License 2.0
13 stars 10 forks source link

Reuse official test suite #4

Closed mpapierski closed 6 years ago

mpapierski commented 6 years ago

We should be able to reuse this: https://raw.githubusercontent.com/ethereum/tests/develop/RLPTests/rlptest.json

mpapierski commented 6 years ago

I think we're fine for what we have. Considering how big effort was that in clarity to support TransactionTests I think we won't benefit much. Also, a lot of tests on Clarity side also touches RLP serialization/deserializations.

Those official tests wouldn't catch problems that could be found in static typed languages, so we'd have to build up our tests anyway. For example: is it easy to convert serde_json::Value into a RLP? Would it work well with different serializer?