search

althea-net / serde-rlp

Ethereum's RLP encoding implemented as a Serde data format
Apache License 2.0
13 stars 10 forks source link

Change to_binary to to_bytes #8

Closed janus closed 6 years ago

janus commented 6 years ago

The name to_binary does not completely reflect what to code returns. It seems like to_bytes or something close to that would be better.

mpapierski commented 6 years ago

Hey @janus,

Thanks for reporting this issue. I think the current name fits the purpose well enough. It takes a number and converts it to its binary form. You're right that it returns bytes, but I think binary is accurate enough for what it does. Its also based on the official design document which you can read here: https://github.com/ethereum/wiki/wiki/RLP

mpapierski commented 6 years ago

@janus I'm closing this one because of lack of activity. If you have any more suggestions I'm happy to help!