althea28 / pe

0 stars 0 forks source link

Phone number limit may not be reasonable #3

Open althea28 opened 1 week ago

althea28 commented 1 week ago

Screenshot 2024-11-15 at 4.25.33 PM.png

Expected

The longest phone number in the world is 15 digits. If the patient is a foreigner with a handphone number longer than 10 digits, their information will not be able to be added to the system. As far as I can tell, no mention of nationality in target user group in the UG (not Singaporean patients, and hence no limit of 8 digits only).

Actual

Phone number is limited to a maximum of 10 digits (as stated in UG).

nus-se-bot commented 1 week ago

Team's Response

It is unlikely for a small clinic to encounter foreign patients, more so for patients whose phone number is more than 10 digits long.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I understand your reasoning if only Singaporean clinics were listed as the target group. However, as noted in the original bug report, your UG and DG do not explicitly mention that the app is only for Singaporean clinics or clinics in countries where phone numbers are guaranteed to be 10 digits or fewer. This lack of specification means the app could reasonably be expected to support clinics in any country.

If the app is used by clinics in a country where phone numbers are >10 digits long, the clinic would not be able to store ANY of their patient's phone numbers. According to the World Population Review, over 20 countries have phone numbers exceeding 10 digits. Clinics in these countries would face significant usability issues.

As per our course website, it is not reasonable to restrict phone numbers to 10 digits (in this case), as there was no specification that the app is targeting users whose telephone numbers are guaranteed to be not more than 10 digits.

Screenshot 2024-11-20 at 9.17.10 PM.png

Hence, I do not believe that the severity of the issue is low, and should be medium, as the inability to store valid phone numbers for entire patient populations in affected countries is not a minor inconvenience. This issue would prevent the app from fulfilling its primary purpose for these users.