althonos / pronto

A Python frontend to (Open Biomedical) Ontologies.
https://pronto.readthedocs.io
MIT License
226 stars 47 forks source link

fix: accept XMLLiterals #223

Closed chrishmorris closed 2 months ago

chrishmorris commented 3 months ago

Fixes #222

althonos commented 3 months ago

Hi @chrishmorris, thanks for the PR! I think you changed the wrong method here, you need to patch _compact_datatype and not _compact_id, unless I'm wrong?

chrishmorris commented 3 months ago

Yes you are correct, thank you.

I will correct this when I can - sorry, I have a crunch in the day job just now.

althonos commented 3 months ago

No problem, just ping me when that's fixed :wink:

chrishmorris commented 2 months ago

Fixed now, it would be great if you decide to adopt this fix. Thank you for Pronto.

althonos commented 2 months ago

Thanks! I'll release a patch.