Closed zdk123 closed 1 year ago
Patch coverage: 100.00
% and project coverage change: -8.52
:warning:
Comparison is base (
d7602f0
) 84.96% compared to head (3885574
) 76.45%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for the fix!
This definitely flew under my radar, I should have done more thorough testing. Do you think you could add a test case to pyhmmer/tests/test_plan7/test_pipeline.py
? There is a test_iterate_seq
method in TestIteratePipeline
, perhaps you could use it as a basis. If you don't have time/energy for this, that's fine, just tell me and I'll merge as is.
I'd be happy to add a test, no worries.
Added the test
Great job, thanks a lot! I'll be making a new release right after.
Related to this, would you have any interest in including a top level jackhmmer interface (pyhmmer.jackhmmer
)? I have this stubbed out locally.
Fixes #33
query
from DigitalSequence to HMM to be consistent with the intention of the function as well as the documentation__next__
method of the iterator, make sure theextra_sequences
andextra_traces
areNone
in iterations after the first, when the query is an HMM. Treating it as a sequence breaks the iterator.