Closed zdk123 closed 1 year ago
Patch coverage: 65.18
% and project coverage change: -0.21
:warning:
Comparison is base (
0f803aa
) 76.43% compared to head (09fe991
) 76.23%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi Zach,
Thanks a lot for this contribution, this is really useful and goes right into the scope of the project, so I'll be happy to get it merged and published in here. I'll try to have a look at the code more in depth this week.
Hi Zach!
Sorry this took so long, I had a busy month :sweat_smile: I fixed some issues regarding the checkpointing and pipeline initialization (because jackhmmer
uses a default incE
and incdomE
compared to the normal pipeline). Otherwise, most of the changes are just updating the type annotations to accomodate for the new query and return types. In particular, mypy
should be able to figure out the return type based on the value of the checkpoints
argument.
Thanks a million @althonos, I figured you'd have opinions on the design and implementation here, happy to have just gotten the ball rolling!
Perfect, let's merge then! I'm not gonna release right away because there are a bunch of breaking changes I want to add for v0.8.0
as well.
Follows up on PR #34 by adding a top-level jackhmmer interface to pyhmmer.
Feel free say this is out of scope with your intentions for this package, but this would bring near-parity to hmmer3 command line utilities.